Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amneziawg-tools: init at 1.0.20240213 #331582

Merged
merged 1 commit into from
Nov 17, 2024
Merged

amneziawg-tools: init at 1.0.20240213 #331582

merged 1 commit into from
Nov 17, 2024

Conversation

averyanalex
Copy link
Contributor

@averyanalex averyanalex commented Aug 1, 2024 •
edited
Loading

Init amneziawg-tools at 1.0.20240213

Censorship-resistant VPN based on wireguard.

https://amnezia.org

Depends on #331574.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@averyanalex averyanalex force-pushed the init-amneziawg-tools branch from b833160 to fd67cfc Compare August 4, 2024 13:07
@averyanalex averyanalex force-pushed the init-amneziawg-tools branch from fd67cfc to 6b22087 Compare August 21, 2024 23:16
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4446

@averyanalex averyanalex force-pushed the init-amneziawg-tools branch from 6b22087 to 580b22d Compare August 22, 2024 10:32
paveloom
paveloom reviewed Sep 12, 2024
View reviewed changes
pkgs/by-name/am/amneziawg-tools/package.nix
Comment on lines +55 to +58
lib.makeBinPath [
procps
iproute2
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When starting the systemd unit, awg-quick complained about readlink missing. I added coreutils here to resolve it.

Copy link
Contributor Author

@averyanalex averyanalex Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked awg-quick@name service, it doen't work, like the wg-quick@name. In wg-quick module some tools, like config.networking.firewall.package are added to service path. I think the best solution is to update wireguard modules and add something like type = wireguard | amneziawg option.

This was referenced Sep 13, 2024
Open
Open
@cab404
Copy link
Member

cab404 commented Nov 15, 2024

@averyanalex anything left there you want to do before merging?

@averyanalex
Copy link
Contributor Author

@averyanalex anything left there you want to do before merging?

New version just released (18.10.2024) with minor improvements, I will update.

Also, what do you think about #331582 (review)? Should "vanilla" systemd services work out of the box?

@cab404
Copy link
Member

cab404 commented Nov 15, 2024 •
edited
Loading

@averyanalex anything left there you want to do before merging?

New version just released (18.10.2024) with minor improvements, I will update.

Also, what do you think about #331582 (review)? Should "vanilla" systemd services work out of the box?

It would be nice if they did. Not everybody have fully nixos managed wg/awg configs.

@averyanalex
Copy link
Contributor Author

@averyanalex anything left there you want to do before merging?

New version just released (18.10.2024) with minor improvements, I will update.
Also, what do you think about #331582 (review)? Should "vanilla" systemd services work out of the box?

It would be nice if they did. Not everybody have fully nixos managed wg/awg configs.

If I add coreutils to PATH, systemd service starts without errors, but uses iptables on nftables system and doesn't work. I think this can be merged as is.

@cab404
Copy link
Member

cab404 commented Nov 17, 2024

@averyanalex anything left there you want to do before merging?

New version just released (18.10.2024) with minor improvements, I will update.
Also, what do you think about #331582 (review)? Should "vanilla" systemd services work out of the box?

It would be nice if they did. Not everybody have fully nixos managed wg/awg configs.

If I add coreutils to PATH, systemd service starts without errors, but uses iptables on nftables system and doesn't work. I think this can be merged as is.

Nice, thank you!

@cab404 cab404 merged commit c0072d3 into NixOS:master Nov 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paveloom paveloom paveloom left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@averyanalex @nixos-discourse @cab404 @SuperSandro2000 @paveloom